hazelcast-csharp-client icon indicating copy to clipboard operation
hazelcast-csharp-client copied to clipboard

Introduce Member Groups and Cluster Version from Auth Message [API-2239] (1/3)

Open emreyigit opened this issue 1 year ago • 3 comments

PR handles new added cluster version and partition group information on both auth response and cluster views. Protocol messages are regenerated, and there are some internal changes to handle parameters. This is the reason of high number of changed lines. Rest of the feature will be implemented on other PRs. (You can see some notes for future work)

You can focus below for logic;

  • MemberPartitionGroup
  • ISubsetClusterMembers
  • ClusterEvents
  • Authenticator
  • Models folder
  • Tests

rest is internal implementation and generated protocol updates.

Protocol PR for .Net Client

emreyigit avatar Jun 21 '24 12:06 emreyigit

Deploy Preview for silly-valkyrie-e996d9 canceled.

Name Link
Latest commit eaaff0fd1869805fd72091d90b445daabb370b17
Latest deploy log https://app.netlify.com/sites/silly-valkyrie-e996d9/deploys/667d17a67f109d000878a58f

netlify[bot] avatar Jun 21 '24 12:06 netlify[bot]

Codecov Report

Attention: Patch coverage is 87.62887% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (9af3414) to head (eaaff0f). Report is 3 commits behind head on master.

Files Patch % Lines
...Protocol/Codecs/ClientAuthenticationCustomCodec.cs 14.28% 6 Missing :warning:
src/Hazelcast.Net/Clustering/Authenticator.cs 84.84% 5 Missing :warning:
...t.Net/Protocol/Codecs/ClientAuthenticationCodec.cs 85.71% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
- Coverage   81.04%   81.03%   -0.02%     
==========================================
  Files        1018     1016       -2     
  Lines       24519    24626     +107     
==========================================
+ Hits        19872    19955      +83     
- Misses       4647     4671      +24     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 25 '24 10:06 codecov-commenter

Thanks, @JamesHazelcast. The generator generates the all codecs on each run. If there is no rule made, new codecs will be included, such as vector. However, it's a static code won't bother the client. Also, hashes indicate the commit hash which is used during generation. I hear you and I'll try to have separate PR for codec related staff.

emreyigit avatar Jun 28 '24 08:06 emreyigit

Replied your comments @gbarnett-hz, thanks. Could you be more specific? Main logic is already from Java side and rest is .Net client internals.

emreyigit avatar Jul 08 '24 09:07 emreyigit