react-check-auth icon indicating copy to clipboard operation
react-check-auth copied to clipboard

Published 20 hours ago • verified publisher icon hasura

TBD Set default value of `loading` to true

Open ichi404gh opened this issue 6 years ago • 3 comments

TBD

Initial value of isLoading is false and userInfo is null, what is obviously inconsistent. That values are passed to Consumer's children and can lead to wrong behavior, as described in https://github.com/hasura/react-check-auth/issues/17, for example.

I suggest to set initial isLoading value to true, so components can rely on both isLoading and userInfo, especially right after rendering.

ichi404gh avatar Mar 05 '19 21:03 ichi404gh

We ran into this issue straight away also, is the repo stale and requiring personal forks? @karthikvt26 are you able to merge and cut a release of the two main feature PRs?

stevenkissack avatar Oct 22 '19 04:10 stevenkissack

Thanks @ichi404gh for the PR. Have been super busy with some work. Will definitely check it out in some time.

@stevokk Will definitely check it out and release them asap.

karthikvt26 avatar Oct 22 '19 14:10 karthikvt26

@karthikvt26 we're starting a new project and pulling the local fix version over, can we get these merged or are you requiring some legwork on our end to help?

stevenkissack avatar Sep 15 '20 12:09 stevenkissack