cabal icon indicating copy to clipboard operation
cabal copied to clipboard

Fix #10042 Don't recommend deprecated/removed 'extensions:' field

Open mpilgrem opened this issue 1 year ago • 6 comments
trafficstars

Related issue:

  • #10042

Include the following checklist in your PR:

  • [x] Patches conform to the coding conventions.
  • [x] Any changes that could be relevant to users have been recorded in the changelog.
  • [x] The documentation has been updated, if necessary. Not necessary.
  • [x] Manual QA notes have been included. None needed.
  • [x] Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!) None needed.

mpilgrem avatar May 22 '24 23:05 mpilgrem

I think the CI is failing for reasons unconnected with this pull request.

mpilgrem avatar May 23 '24 06:05 mpilgrem

Yes, we're working on it.

geekosaur avatar May 23 '24 09:05 geekosaur

@geekosaur I don't know that anyone is working on the changelog.d/GHC 9.10 failure btw! Maybe you could give it a try? Hécate suggested that instead of building it, we could just download a bindists...

ulysses4ever avatar May 23 '24 10:05 ulysses4ever

I stand corrected: the changelog-d issue is being worked on here: https://github.com/haskell/cabal/pull/10048

ulysses4ever avatar May 23 '24 14:05 ulysses4ever

I've rebased on master.

mpilgrem avatar May 25 '24 22:05 mpilgrem

@mpilgrem awesome! Per CONTRIBUTING.md, do you want to apply a merge label (either merge me or squash+merge). Squashing makes more sense, I think.

ulysses4ever avatar May 26 '24 01:05 ulysses4ever

I've tidied-up manually.

mpilgrem avatar May 26 '24 07:05 mpilgrem

@mergify backport 3.12

ulysses4ever avatar Jun 06 '24 15:06 ulysses4ever

backport 3.12

✅ Backports have been created

mergify[bot] avatar Jun 06 '24 15:06 mergify[bot]