alex icon indicating copy to clipboard operation
alex copied to clipboard

Published 20 hours ago • verified publisher icon haskell

Use unsafeShiftR in utf8Encode

Open sjakobi opened this issue 7 years ago • 3 comments
trafficstars

That could be a tiny bit faster than the current use of shiftR.

Since unsafeShiftR has been in base since v4.5 / GHC-7.4, could it even be used unconditionally?! alex currently claims a rather dubious lower bound on base of >= 1.0…

sjakobi avatar Nov 21 '18 06:11 sjakobi

It is not entirely clear to me which GHC versions Alex wants to support. The currently lowest version tested on travis is 7.0.4. (See ae56173317700b117cd50b97176178a70e75af95.)

andreasabel avatar Jan 26 '20 20:01 andreasabel

Let's keep support for 7.0.4 while it still works. If it becomes hard to support/test older versions we can increase the lower bound in the future.

simonmar avatar Jan 27 '20 08:01 simonmar

NB: The current (3.2.7) lower bound on base is >= 2.1. GHC-7.0 is 4.3.

andreasabel avatar Jan 25 '22 09:01 andreasabel