servant icon indicating copy to clipboard operation
servant copied to clipboard

Exported Servant.Links.addQueryParam

Open saurabhnanda opened this issue 1 year ago • 4 comments

Closes #1232

saurabhnanda avatar Sep 23 '24 08:09 saurabhnanda

@saurabhnanda Thanks a lot for this!

Could you please add a new changelog entry in the changelog.d file? Just like this one https://github.com/haskell-servant/servant/blob/master/changelog.d/issue-1780

tchoutri avatar Sep 23 '24 08:09 tchoutri

@saurabhnanda Thanks a lot for this!

Could you please add a new changelog entry in the changelog.d file? Just like this one https://github.com/haskell-servant/servant/blob/master/changelog.d/issue-1780

@tchoutri I had created a branch from v0.20.2 and not master. I believe changelog.d has been introduced in master, along with some GHC-related deprecations? Are those intended? Because I am unable to build servant on Stack LTS-18.28 if I swtich to master branch.

       
       In the dependencies for servant-0.20.3:
         * base must match >=4.16.4.0 && <4.21, but base-4.14.3.0 is in the Stack configuration (latest matching version is 4.20.0.1).
         * bytestring must match >=0.11 && <0.13, but bytestring-0.10.12.0 is in the Stack configuration (latest matching version is 0.12.1.0).
       The above is/are needed since servant is a build target.

saurabhnanda avatar Sep 24 '24 06:09 saurabhnanda

@saurabhnanda changelog-d has been around for quite some time, if I'm not mistaken.

Regarding the GHC deprecations: yes they are intended, see https://github.com/haskell-servant/servant/pull/1778.

You will need to update the Stack setup to use the LTS of 9.6.6.

tchoutri avatar Sep 24 '24 08:09 tchoutri

@tchoutri added the changelog entry - hope it's fine.

saurabhnanda avatar Sep 24 '24 10:09 saurabhnanda

@saurabhnanda ping! I'd like to get this merged for 0.20.3.0 :)

tchoutri avatar Mar 05 '25 13:03 tchoutri

@tchoutri please give me a day -- I just got back from vacation. Will update the PR.

saurabhnanda avatar Mar 06 '25 13:03 saurabhnanda

@saurabhnanda no worries :)

tchoutri avatar Mar 24 '25 13:03 tchoutri