vscode-terraform icon indicating copy to clipboard operation
vscode-terraform copied to clipboard

Update MSW to 2.0

Open kettanaito opened this issue 1 year ago • 3 comments

Hi! I know you are using MSW so I decided to update your stack to the latest 2.0 version of the library. That version introduces a bunch of improvements and bug fixes, as well as brings MSW closer to the platform since it now relies on the standard Fetch API primitives.

Let me know in case I missed anything!

kettanaito avatar Dec 27 '23 11:12 kettanaito

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Dec 27 '23 11:12 hashicorp-cla

Thank you for raising this PR! ⭐

I've opened https://github.com/hashicorp/vscode-terraform/pull/1659 to address the test failures on main, which should resolve most of the failed tests.

I'll be talking to the team about how to handle 1.75.1, which is currently our lowest supported engine version and therefore part of our test matrix. 1.75.1 still uses Node 16 under the hood and fails due to lack of fetch support. Only VS Code 1.82 and higher will ship with an updated Electron version and use Node 18.

dbanck avatar Jan 02 '24 14:01 dbanck

Got it, @dbanck. Thanks for the update! Let me know if you need any help with these changes once you upgrade the Node version. I confirm this runs great on Node.js 18.

kettanaito avatar Jan 03 '24 10:01 kettanaito

This is rebased and ready to merge, once https://github.com/hashicorp/vscode-terraform/pull/1718 is merged

jpogran avatar Apr 09 '24 19:04 jpogran

Thank you for the contribution @kettanaito !

jpogran avatar Apr 15 '24 13:04 jpogran

Yohoo! 🚀 Let me know if you have any questions about MSW, I would be happy to help.

Also, if you find it great to work with, please consider Becoming a Sponsor. That would be amazing! Thanks.

kettanaito avatar Apr 15 '24 15:04 kettanaito

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar May 16 '24 03:05 github-actions[bot]