Move from allowing vault keys of 512 to 1024

[michaeljs1990]

We ran into issues with people going over the 512 key length limit in production. We modified the table to be 1024 which seems like a reasonably long key length to allow for now.

[hashicorp-cla]

All committers have signed the CLA.

[aphorise]

Hey @michaeljs1990 any chance you can:

1. Resolve merge conflict.
2. Detail the use case that's caused this? - It would be good to understand if there may be other potential scenarios where this may need to be adjusted further.

[michaeljs1990]

Hey @michaeljs1990 any chance you can:

1. Resolve merge conflict.
2. Detail the use case that's caused this? - It would be good to understand if there may be other potential scenarios where this may need to be adjusted further.

I'm good to close this out. This was an issue we ran into were someone was getting a really bad error when trying to add a key with a really really long name (over 512) chars. Although in my case I just bumped it really in most cases people shouldn't run into this and since no one has commented on this in ~3 years now I think that is a safe assumption.

Since keys are stored in a string and the various backends have different limitations I think the real solution would be.

Adding a new function to the backend interface that is something like SupportedKeyLength and have checks in place on insert to return an error message around only supporting a max size of X.

I have setup several different vault instances since then and just use the internal raft DB which is better supported.