vault icon indicating copy to clipboard operation
vault copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Fixed Oauth redirect not working on Android Chrome

Open prajnamohan1 opened this issue 2 years ago • 1 comments

This fixes the issue described in https://github.com/hashicorp/vault/issues/16778. Navigation is blocked in Android chrome while redirecting back after OIDC authentication. The issue is explained by the lead maintainer of AppAuth(https://stackoverflow.com/a/41882732). The latest Chrome version redirects to the app only if triggered by the user and not automatically redirect. Hence, a link is added in the UI to redirect back to the app.

prajnamohan1 avatar Dec 21 '22 14:12 prajnamohan1

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Dec 21 '22 14:12 hashicorp-cla

Thanks for this contribution, @prajnamohan1! @siepkes would you be able to see if this fixes your issue?

austingebauer avatar Jan 02 '23 17:01 austingebauer

@austingebauer I can confirm this fixes the issue (I verified it). But to clarify @prajnamohan1 is a co-worker of mine. I asked her to investigate this issue.

siepkes avatar Jan 03 '23 21:01 siepkes

@hashishaw Hi! I've made the requested changes! Is there something else I need to change?

prajnamohan1 avatar Jan 13 '23 16:01 prajnamohan1

Great to see the PR was approved! Is there anything you need from @prajnamohan1 or me in order to be able to merge the change? Let us know!

siepkes avatar Mar 16 '23 07:03 siepkes