Change address lookup behaviour if VAULT_SRV_LOOKUP is set.

[gounselor]

I think the behaviour of VAULT_SRV_LOOKUP is strange: It should not expect http (what about a prod https setup?) And actually the VAULT_ADDR should not contain a scheme in this case.

I made a minimal change to make it work for us. We are using SRV records like _vault._tcp.example.domain which return a list of hosts with the port appended.

The impure thing is that it overrides the scheme to be https, because i expect to use a SRV record approach in prod only which should https.

I am not 100% sure if this is the correct way, maybe we should discuss how to work with SRV records.

EDIT: fixed typos

[hashicorp-cla]

All committers have signed the CLA.

[heatherezell]

Hello @gounselor - is this in relationship to an open issue? We ask that PRs be linked to an existing issue, so discussions about the desired solution can be hashed out there. Thanks!

[gounselor]

Hi,

no, it’s not but i could open one if this is required.

Best regards,

Michael

On 22. Feb 2022, at 23:05, Heather Simon @.***> wrote:

Hello @gounselor - is this in relationship to an open issue? We ask that PRs be linked to an existing issue, so discussions about the desired solution can be hashed out there. Thanks!

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.

[heatherezell]

Hi, no, it’s not but i could open one if this is required. Best regards, Michael … On 22. Feb 2022, at 23:05, Heather Simon @.***> wrote: Hello @gounselor - is this in relationship to an open issue? We ask that PRs be linked to an existing issue, so discussions about the desired solution can be hashed out there. Thanks! — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.

Please do - as I mentioned, we prefer to encourage discussion of the problem as well as its solution, to make sure that all the angles are covered. Thanks! :)