vault-guides icon indicating copy to clipboard operation
vault-guides copied to clipboard

fixed sentinel policy

Open Andrew-Klaas opened this issue 6 years ago • 2 comments

Andrew-Klaas avatar Oct 10 '19 12:10 Andrew-Klaas

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Oct 10 '19 12:10 hashicorp-cla

One more important comment. I believe valid_principals could be a string containing multiple valid principals. So, checking equality on this is probably not right. Instead, you should check if identity.entity.aliases[0].name is in request.data.valid_principals. You could do this with request.data.valid_principals contains identity.entity.aliases[0].name

rberlind avatar Oct 10 '19 15:10 rberlind