gcs backend: fix race condition on locking

[oprudkyi]

• when Lock can't write lock file it tries to read exists lock file via lockError() and lockInfo()
• there is some probability that there already no file (deleted by other process) and lockInfo() and lockError() returns error without filled Info field and info.ID
• but LockWithContext() expects either no error or filled err.Info.ID
• for such a case the patch returns dummy err.Info.ID so waiting for real lock continues

Fixes #30149

Target Release

1.4.x

Draft CHANGELOG entry

BUG FIXES

• Fixed crash when many concurrent processes trying to obtain the same lock

[hashicorp-cla]

All committers have signed the CLA.

[crw]

Thanks for this submission! I've notified the appropriate team.

[oprudkyi]

Hi @crw Could you please ask team if there any way to check and process PR ? Because the issue hurts regularly

[crw]

I have done so. The backends are maintained by each providerer team, in this case the Google / GCP provider team. Backend maintenance is generally not prioritized as highly as provider work, so unfortunately it is difficult to predict when the team might be able to work this into their schedule. Thanks for your submission and persistence!

[oprudkyi]

Hi @crw I have tried all possible ways to reach google team, even via google paid support and there is no activity. May be it is possible to make an exception to the rules and someone from hashicorp probably can take a look. Because we have this bug daily and it make our lives miserable (it breaks pipelines, leaves lock files etc )

[crw]

I have been referring to the Google Cloud Provider team at HashiCorp, not a team at Google. I have raised it a number of times with that team. If you are a paying customer of HashiCorp Terraform Cloud or Enterprise, you can further raise the issue with paid support: https://support.hashicorp.com/hc/en-us. Thanks!

[oprudkyi]

@crw oh, now I understand why Google support was confused by my request. I now owe them an apology

[crw]

Yes, my apologies, I could have been clearer. In the future I will be clearer about that.

[oprudkyi]

is anything can be done here to move it forward ?

[crw]

@oprudkyi My apologies, I do not have much control over the review of backend PRs. I did ping the team again with your request.

[oprudkyi]

Fixed in other tool. closing it now as irrelevant

[crw]

Re-opening so the GCS team can review this PR.