terraform icon indicating copy to clipboard operation
terraform copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Added Quiet value

Open itspooya opened this issue 3 years ago • 1 comments

Added Quiet value in order to quiet the output from local-exec

Fixes #32097

Target Release

1.4.x

Draft CHANGELOG entry

NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS

itspooya avatar Oct 29 '22 16:10 itspooya

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Oct 29 '22 16:10 hashicorp-cla

Thanks for this submission. Although I cannot commit to having this PR reviewed at this time, we acknowledge your contribution and appreciate it. Thanks again for the submission!

crw avatar Nov 01 '22 00:11 crw

Thank you @crw

itspooya avatar Nov 04 '22 12:11 itspooya

@crw Hi Is there anything I can do about this PR? I wanted to send some other PRs too Thank you

itspooya avatar Nov 07 '22 20:11 itspooya

@itspooya Thanks, we are running it by the team. If it looks OK to accept, then there may be changes requested during review.

With regards to other PRs, just be mindful of our contributing guidelines, particularly: https://github.com/hashicorp/terraform/blob/main/.github/CONTRIBUTING.md#proposing-a-change. Your PRs are more likely to be accepted if the solution has already been discussed in the Github issue you are attempting to close. Thanks!

crw avatar Nov 07 '22 21:11 crw

@crw Thanks, I am looking forward to improve and being mindful of your contributing guidelines Also I had a question regarding Vercel and how to authorize to fix the tests Best Regards Pooya

itspooya avatar Nov 08 '22 15:11 itspooya

Also I had a question regarding Vercel and how to authorize to fix the tests

There has been some confusion about this; basically before merging a HashiCorp employee can authorize the test to run successfully. It is only needed for a documentation change. Thanks!

crw avatar Nov 09 '22 00:11 crw

@crw Hey I just wanted to check whether this pull request would be merged or not?

itspooya avatar Jan 19 '23 10:01 itspooya

@itspooya This one seems to have got lost in the shuffle. Let me follow up with the team and get back to you.

crw avatar Jan 19 '23 20:01 crw

@kmoe Please check it, Thanks

itspooya avatar Jan 20 '23 18:01 itspooya

@crw Hello, could you check it please? Thanks

itspooya avatar Jan 24 '23 12:01 itspooya

It is being discussed by the team. I will see if there is a resolution.

crw avatar Jan 24 '23 22:01 crw

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

github-actions[bot] avatar Jan 25 '23 16:01 github-actions[bot]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Feb 25 '23 02:02 github-actions[bot]