fix: Update `sync_time_with_host` to default to `true`

[tenthirtyam]

Description

Update sync_time_with_host to default to true, per VMware recommendation. This is the default recommendation when creating a virtual machine via UI, API, PowerCLI, et al.

Additional reference: https://kb.vmware.com/s/article/1189

VMware Tools performs two types of time corrections:

One-off time sync: Guest system clock is synchronized to host time upon specific VM life-cycle events that can cause guest** clock to become incorrect, such as resuming from vMotion or a snapshot. This capability is recommended for use and turned ON by default.

Periodic time sync: Guest system clock is periodically (every 60 seconds) synchronized to track host time. It is recommended that guests use a native time synchronization service – such as NTPD or Chrony in Linux based operating systems, and W32Time for Microsoft Windows. If that's not viable, periodic time sync provides an alternative. This capability is turned OFF by default.

This has been confirmed with VMware engineering "time-lords".

Release Note

⚠️ Breaking Change resource/virtual_machine: Set sync_time_with_host to default to true per VMware recommendations. The guest operating system synchronizations its clock with the host when the virtual machine is powered on or resumed. [GH-1563]

References

Closes #1443

[hashicorp-cla]

All committers have signed the CLA.

[tenthirtyam]

Marked as draft to avoid accidental merge before next major. Also needs merge conflict resolution.

Ryan Johnson Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

[tenthirtyam]

Merge conflict resolved.

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

[github-actions[bot]]

This functionality has been released in v2.6.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.