terraform-provider-vsphere icon indicating copy to clipboard operation
terraform-provider-vsphere copied to clipboard

fix: Update `vsphere_content_library` defaults for subscribed libraries

Open tenthirtyam opened this issue 4 years ago • 3 comments

Description

  • Sets automatic_sync as Default: true to align with the default behavior in the vSphere UI. Sets on_demand as Default: false

Acceptance tests

  • [ ] Have you added an acceptance test for the functionality being added?
  • [ ] Have you run the acceptance tests on this branch?

None. Performed a go get and go build to perform positive and negative unit tests.

Release Note

⚠️ Breaking Changes

  • resource/vsphere_content_library: Sets automatic_sync as Default: true on a subscribed content library to align with the default behavior in the vSphere UI. Sets on_demand as Default: false [GH-1502]
  • resource/vsphere_content_library: Updates resource documentation example for storage_backing attribute. [GH-1502]

References

Resolves #1426 by @tenthirtyam.

tenthirtyam avatar Oct 27 '21 22:10 tenthirtyam

Let me know if you have any additional question @appilon - happy to review over Zoom, too. :)

tenthirtyam avatar Jan 20 '22 05:01 tenthirtyam

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Mar 12 '22 16:03 hashicorp-cla

Converted to draft to avoid accidental merge before next major.

Ryan Johnson Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

tenthirtyam avatar Sep 11 '22 21:09 tenthirtyam

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Dec 11 '23 02:12 github-actions[bot]