feat: Add support for vGPU

[aarnaud]

Description

Original implementation of PciPassthrough can't be use for vGPU because it's link to host systemId This PR add support for vGPU

Acceptance tests

• [ ] Have you added an acceptance test for the functionality being added?
• [x] Have you run the acceptance tests on this branch?

Release Note

Release note for CHANGELOG:

support vGPU

References

Resolves #1265

[hashicorp-cla]

All committers have signed the CLA.

[tenthirtyam]

@appilon, I've requested access to a GPU-enabled testbed to review and evaluate this pull request.

Ryan

[tenthirtyam]

May wish to consider finding the devices with VirtualDeviceList.SelectByBackingInfo that will be in in a future govmomi version.

See. https://github.com/vmware/govmomi/pull/2772

[tenthirtyam]

Hi @aarnaud,

I hope all is well. As one of the project collaborators, I've started to review this pull request and run some tests in one of my available testbeds.

I know it's been a while, but if you could share any example config and the guest OS(s) and GPUs tested in this would be most helpful.

You can reply here or direct, if you like.

Ryan Johnson Staff II Solutions Architect | VMware, Inc. [email protected]

[aarnaud]

Hi, sorry for the delay,

An example:

resource "vsphere_virtual_machine" "vm" {
  ...
  firmware           = "efi"
  shared_pci_device_id = "grid_rtx8000-8q"
  ...
}

Maybe there is an other way now with latest version

[tenthirtyam]

Thanks for the update, @aarnaud. I'll run another couple tests in the testbed to see if the expected results stick.

Ryan Johnson Staff II Solutions Architect | VMware, Inc.

[wilmardo]

@tenthirtyam Is there any update on this? Could we do some testing to help this further along?

It would be awesome to have this merged and released :)

[tenthirtyam]

Hi @wilmardo - at this time it's not planned for the v2.3.0 release milestones. If you have the availability to contribute, please build and test the branch/fork of the provider with the proposed changes to share your findings.

Ryan Johnson Staff II Solutions Architect | VMware, Inc.

[tenthirtyam]

Merge conflicts resolved to aid when next reviewed for consideration. No ETA.

Ryan Johnson Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

[Archicake]

@tenthirtyam Hi, do you have any idea when this will be released?

[tenthirtyam]

There's still a need for further testing on the pull request and to ensure it's the best implementation.

Note that if you look at the Milestone here in GitHub it's parked in the Backlog.

If you'd like to review and test the pull request by building from source, feedback and contributions are welcome.

[mristok]

@tenthirtyam What is the status of the PR? What needs to happen to get this merged?

[tenthirtyam]

@tenthirtyam What is the status of the PR? What needs to happen to get this merged?

https://github.com/hashicorp/terraform-provider-vsphere/pull/1378#issuecomment-1332379209

[mristok]

What is the "further testing" you are referring to in the comment?

I would like to see this brought to completion, so I will start where @aarnaud left off and see what needs to get completed.

[aarnaud]

I'm not using this anymore, It was more a PoC. Feel free to take over the PR

[tenthirtyam]

superseded by https://github.com/hashicorp/terraform-provider-vsphere/pull/2113

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.