Evaluate and fix warnings generated by `bflad/tfproviderlint`

[aareet]

trafficstars

Evaluate and fix warnings generated by https://github.com/bflad/tfproviderlint

Debug Output

/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/helper/customattribute/custom_attributes_helper.go:70:8: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/helper/structure/structure_helper.go:118:15: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/helper/structure/structure_helper.go:152:15: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/helper/structure/structure_helper.go:193:15: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/helper/structure/structure_helper.go:270:15: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/helper/structure/structure_helper.go:378:15: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/helper/structure/structure_helper.go:396:15: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/helper/structure/structure_helper.go:424:15: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/helper/structure/structure_helper.go:473:15: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/helper/structure/structure_helper.go:591:19: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/virtualdevice/virtual_machine_cdrom_subresource.go:151:18: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/virtualdevice/virtual_machine_cdrom_subresource.go:278:15: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/virtualdevice/virtual_machine_cdrom_subresource.go:393:18: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/virtualdevice/virtual_machine_disk_subresource.go:297:18: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/virtualdevice/virtual_machine_disk_subresource.go:526:15: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/virtualdevice/virtual_machine_disk_subresource.go:1045:18: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/virtualdevice/virtual_machine_disk_subresource.go:1123:18: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/virtualdevice/virtual_machine_network_interface_subresource.go:220:18: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/virtualdevice/virtual_machine_network_interface_subresource.go:359:15: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/internal/virtualdevice/virtual_machine_network_interface_subresource.go:500:18: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/distributed_virtual_switch_structure.go:482:9: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/distributed_virtual_switch_structure.go:483:9: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/resource_vsphere_datastore_cluster.go:704:19: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/resource_vsphere_datastore_cluster.go:754:19: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/resource_vsphere_datastore_cluster.go:799:19: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/resource_vsphere_datastore_cluster.go:846:19: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/tags_helper.go:253:18: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/virtual_machine_config_structure.go:512:9: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/virtual_machine_config_structure.go:513:9: R001: ResourceData.Set() key argument should be string literal
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/host_network_policy_structure.go:36:18: S013: schema should configure one of Computed, Optional, or Required
/Users/aareet/go/src/github.com/aareet/terraform-provider-vsphere/vsphere/host_network_policy_structure.go:41:19: S013: schema should configure one of Computed, Optional, or Required

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[tenthirtyam]

Alex (@appilon) - does the team still use bflad/tfproviderlint on the providers?

Perhaps getting these resolved and then including this as a GHA might be worthwhile?

Ryan

[appilon]

I will have to get back to you on what the other providers have standardized on in terms of linting, tfproviderlint was built around avoiding common tropes in provider development so it's likely a good idea to integrate it into the project.