terraform-provider-vault
terraform-provider-vault copied to clipboard
Add tune support for resource_okta_auth_backend
Community Note
- Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
- Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request
Changes
This change adds support for tune in Okta auth. It's based on the way this was implemented withresource_github_auth_backend.
Release note for CHANGELOG:
- Adds support to `resource_okta_auth_backend` for common backend tune params
Output from acceptance testing:
$ make testacc TESTARGS='-run=OktaAuthBackend'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./vault -v --run OktaAuthBackend -timeout 120m
=== RUN TestAccOktaAuthBackendGroup_basic
--- PASS: TestAccOktaAuthBackendGroup_basic (0.32s)
=== RUN TestAccOktaAuthBackendGroup_specialChar
--- PASS: TestAccOktaAuthBackendGroup_specialChar (0.30s)
=== RUN TestAccOktaAuthBackend
--- PASS: TestAccOktaAuthBackend (0.52s)
=== RUN TestAccOktaAuthBackendUser
--- PASS: TestAccOktaAuthBackendUser (0.26s)
PASS
ok github.com/hashicorp/terraform-provider-vault/vault 2.669s
Is anything needed to help get this change merged? The okta_auth_backend resource needs this functionality in order to do any sort of auth tuning since the auth_backend resource does not appear to be an option for using the Okta auth features. This change looks complete to me, but I'm happy to help in any way that can facilitate this being merged.
I can resolve conflicts and dust this off but I wasn't able to get any reviews for it
@FalconerTC Hello, are you still interested in carrying this forward?