terraform-provider-vault
terraform-provider-vault copied to clipboard
Add ext_key_usage_oids to vault_pki_secret_backend_role
Community Note
- Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
- Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request
Release note for CHANGELOG:
resource/pki_secret_backend_role: Add support for ext_key_usage_oids
Output from acceptance testing:
$ make testacc TESTARGS="--run TestPkiSecretBackendRole"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./...) -v --run TestPkiSecretBackendRole -timeout 120m
? github.com/hashicorp/terraform-provider-vault [no test files]
? github.com/hashicorp/terraform-provider-vault/cmd/coverage [no test files]
? github.com/hashicorp/terraform-provider-vault/cmd/generate [no test files]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/codegen 0.018s [no tests to run]
? github.com/hashicorp/terraform-provider-vault/generated [no test files]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode 0.034s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode 0.072s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet 0.056s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role 0.016s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template 0.034s [no tests to run]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation 0.016s [no tests to run]
? github.com/hashicorp/terraform-provider-vault/schema [no test files]
testing: warning: no tests to run
PASS
ok github.com/hashicorp/terraform-provider-vault/util 0.065s [no tests to run]
=== RUN TestPkiSecretBackendRole_basic
--- PASS: TestPkiSecretBackendRole_basic (0.39s)
PASS
ok github.com/hashicorp/terraform-provider-vault/vault 0.407s...
Hey @danielpops , this is still lacking a review, and it has almost been a year 😅. Any advice on how to proceed?
@alves-luis I'm not a maintainer. I've submitted two PRs to this repo and they both took almost a year to get reviewed/shipped. I don't have any further insight into the operations at hashicorp so I'm not sure if there's anything you can really do to expedite it 😅
Hi @danielpops . Yeah, thank you for the insight though :)!
Is there anything one could do to move this ahead? I'm using this for my smartcard lab and while you can just patch the role and have terraform not revert it, I'd love for this to not be a manual step.
superseded by #2108