terraform-provider-kubernetes
terraform-provider-kubernetes copied to clipboard
kubernetes_manifest flag to skip validation during plan
Description
The common walkaround for missing CRDs is to use other providers like kubectl_manifest or helm_release. The deferred flag on kubernetes_manifest will be more elegant solution, with the same downsides.
Acceptance tests
- [ ] Have you added an acceptance test for the functionality being added?
- [ ] Have you run the acceptance tests on this branch?
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX'
...
Release Note
Release note for CHANGELOG:
...
References
Community Note
- Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
- If you are interested in working on this issue or have submitted a pull request, please leave a comment
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Daniel Haba seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.
Hi Daniel,
I hate to be a spoiler here, but this approach is not going to work.
The kubernetes_manifest resource doesn't just do validation during the plan, it actually retrieves the schema for the resource from the OpenAPI definition available on the cluster API. Even if you could get away with what this PR proposes, there still is a need for schema information. There is no way to work around that, as Terraform requires a uniform and consistent resource structure throughout the lifecycle of the resource.
Just wanted to let you know that we can't merge this kind of change. I do agree the internals of the kubernetes_manifest should be better documented from a developer POV in order to avoid wasting effort like this.
Hi Daniel,
I hate to be a spoiler here, but this approach is not going to work. The
kubernetes_manifestresource doesn't just do validation during the plan, it actually retrieves the schema for the resource from the OpenAPI definition available on the cluster API. Even if you could get away with what this PR proposes, there still is a need for schema information. There is no way to work around that, as Terraform requires a uniform and consistent resource structure throughout the lifecycle of the resource.Just wanted to let you know that we can't merge this kind of change. I do agree the internals of the
kubernetes_manifestshould be better documented from a developer POV in order to avoid wasting effort like this.
Closing this PR with the reasoning mentioned from a previous comment.