terraform-provider-kubernetes
terraform-provider-kubernetes copied to clipboard
hashicorp
Updating Contribution Guide
Description
Acceptance tests
- [ ] Have you added an acceptance test for the functionality being added?
- [ ] Have you run the acceptance tests on this branch?
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX'
...
Release Note
Release note for CHANGELOG:
...
References
Community Note
- Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
- If you are interested in working on this issue or have submitted a pull request, please leave a comment
Wanted to add a quirk I noticed, while using Docker Desktop on Mac, despite /Users/ being added to file sharing by default, the seccomp profile needed during a few tests located in ./.github/config/seccomp-profiles does not appear to be accessible during the tests.
Very oddly, adding the mount destination folder to the file sharing settings in Docker Desktop (you have to type it out and hit enter, clicking the + icon will open Finder for your to choose a local directory), fixes the issue. I can't explain why adding where the folder gets mounted to within containers matters at all 🤷♂️.
May want to make special note of this in the guide if the seccomp local profile tests fail. I suspect some kind of bug in Docker Desktop or perhaps default file/folder permissions of a github repo are in conflict?
