terraform-provider-kubernetes icon indicating copy to clipboard operation
terraform-provider-kubernetes copied to clipboard

kubernetes_server_version data source

Open daemon4d-us opened this issue 2 years ago • 9 comments

Description

Acceptance tests

  • [ Yes] Have you added an acceptance test for the functionality being added?
  • [ Yes] Have you run the acceptance tests on this branch?

Output from acceptance testing:

dsidorenko@dsidorenko01-la terraform-provider-kubernetes % make testacc TESTARGS='-run=TestAccKubernetesDataSourceServerVersion_basic'
==> Checking that code complies with gofmt requirements...
go vet .
TF_ACC=1 go test "/Users/dsidorenko/go/src/github.com/hashicorp/terraform-provider-kubernetes/kubernetes" -v -vet=off -run=TestAccKubernetesDataSourceServerVersion_basic -parallel 8 -timeout 3h
=== RUN   TestAccKubernetesDataSourceServerVersion_basic
=== PAUSE TestAccKubernetesDataSourceServerVersion_basic
=== CONT  TestAccKubernetesDataSourceServerVersion_basic
--- PASS: TestAccKubernetesDataSourceServerVersion_basic (3.64s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   4.069s

Release Note

Release note for CHANGELOG:

data kubernetes_server_version added. 
...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

daemon4d-us avatar Oct 05 '23 06:10 daemon4d-us

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Oct 05 '23 06:10 hashicorp-cla

Hi @torqu3e Does this look better?

daemon4d-us avatar Oct 10 '23 22:10 daemon4d-us

@daemon4d-us Changes generally look good and this is a useful feature to have in the provider. In order for community PRs to be merged contributors need to agree to the CLA. Please see the prompt above from hashicorp-cla bot.

alexsomesan avatar Oct 11 '23 09:10 alexsomesan

Hm, something is not working quite good here for me. I have actually signed the CLA, but still appears in Pending state here.

daemon4d-us avatar Oct 11 '23 16:10 daemon4d-us

Hm, something is not working quite good here for me. I have actually signed the CLA, but still appears in Pending state here.

As far as I can see, 2 out of 3 commits including the initial one were made by a user @dsidorenkonx and you have opened this PR from the username @daemon4d-us. That could be a reason why the CLA is still pending signing.

Please update the provider documentation with a new data source and add a change log file.

Thanks!

arybolovlev avatar Oct 12 '23 07:10 arybolovlev

@arybolovlev Thanks for figuring this out. The CLA check is green now. But since I've changed history the PR needs one more approval.

daemon4d-us avatar Oct 12 '23 16:10 daemon4d-us

Anyone can take a look one more time?

daemon4d-us avatar Oct 17 '23 05:10 daemon4d-us

Please refer to @arybolovlev's comments, still missing documentation and changelog entry in order for this PR to get merged.

BBBmau avatar Dec 04 '23 19:12 BBBmau

any update on this? @daemon4d-us

BBBmau avatar Jan 08 '24 17:01 BBBmau