terraform-provider-kubernetes icon indicating copy to clipboard operation
terraform-provider-kubernetes copied to clipboard

Daemonset RollingUpdate Max Surge support

Open abby-gourlay opened this issue 2 years ago • 2 comments

Description

Currently the terraform provider doesn't support a max_surge argument in the rolling update configuration for a daemonset. However according to the Kubernetes documentation this should be possible

This attribute is in our existing daemonsets on our EKS 1.23 cluster image

Potential Terraform Configuration

strategy {
      type = "RollingUpdate"
      rolling_update {
        max_unavailable = 0
        max_surge = "50%"
      }
    }

References

Terraform documentation: https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/daemonset#rolling_update

Kubernetes documentation: https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#:~:text=updateStrategy.rollingUpdate.-,maxSurge,-(IntOrString)

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

abby-gourlay avatar May 17 '23 10:05 abby-gourlay

would like to work on this. can I take this up?

iamunni avatar Jun 05 '23 14:06 iamunni

Marking this issue as stale due to inactivity. If this issue receives no comments in the next 30 days it will automatically be closed. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. This helps our maintainers find and focus on the active issues. Maintainers may also remove the stale label at their discretion. Thank you!

github-actions[bot] avatar Jun 05 '24 00:06 github-actions[bot]

This has been implemented at some point, and I've used it successfully now

abby-gourlay avatar Sep 19 '25 12:09 abby-gourlay