terraform-provider-kubernetes icon indicating copy to clipboard operation
terraform-provider-kubernetes copied to clipboard

Add namespace_selector to pod's affinities

Open artemvang opened this issue 2 years ago • 4 comments

Description

This change adds new attribute namespace_selector to the kubernetes_pod resource (affinities section). See https://github.com/hashicorp/terraform-provider-kubernetes/issues/1826.

Acceptance tests

  • [ ] Have you added an acceptance test for the functionality being added?
  • [ ] Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

artemvang avatar Feb 27 '23 12:02 artemvang

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Feb 27 '23 12:02 hashicorp-cla

Hello! Thank you for opening this PR @artemvang. Could you also add some tests for the namespace_selector attribute as well?

BBBmau avatar May 10 '23 14:05 BBBmau

Hello, any update on this ?

nox-404 avatar Dec 21 '23 15:12 nox-404

@artemvang pinging to know if you're still interested in contributing with this PR. It would be a great addition. Only thing missing is a test that checks for the namespace_selector attribute. You can reference how other attributes are checked within other resources in the repo.

BBBmau avatar Dec 21 '23 16:12 BBBmau