terraform-provider-http
terraform-provider-http copied to clipboard
[fixes 254] Add mTLS support with client cert and key.
This PR is to support mTLS support for the http data source, by allowing the client_cert and client_key to be passed.
- See also https://github.com/hashicorp/terraform/pull/31699
- See also #254
@kmoe can you help merge this one too? It's for non-backend http to use mTLS as well
Hello. Do you now why this merge request is pending because this is a very usefull feature?
Hi @scr-oath and @dlanoire 👋
I have approved the workflow but I'm afraid that reviewing this PR is currently on-hold as we need to triage the changes and our team’s focus is currently elsewhere at the moment.
@bendbennett
Hi @scr-oath and @dlanoire 👋
I have approved the workflow but I'm afraid that reviewing this PR is currently on-hold as we need to triage the changes and our team’s focus is currently elsewhere at the moment.
I just ran make generate to appease the diff checker - do you know what the ETA might be for triage? Will this be looked at / considered even if lower priority than current attention?
@scr-oath I have added this PR to our triage list and will endeavour to discuss this as a team in an upcoming triage meeting. The PR will be considered but it is hard to give a definitive answer on ETA.
Hi @scr-oath 👋
Thank you for submitting this PR and opening the associated issue. We have just discussed this PR at our triage meeting and have come to the conclusion that we'd like to hold off on reviewing and potentially merging until we have a clearer idea on the level of community interest in these changes.
We have to consider each enhancement request (issue) or PR on the basis of community interest alongside the consequences of increasing the surface area of the provider. We will leave the issue and PR open and will revisit if there is community interest signalled by up votes.