terraform-provider-helm icon indicating copy to clipboard operation
terraform-provider-helm copied to clipboard

Tweak sensitive values appearence in diff to not be b64-encoded

Open kkopachev opened this issue 3 years ago • 1 comments

Description

When sensitive value within a secret is replaced with string like (sensitive value 123456789), upon converting it to json, it is base64-encoded which creates string like KHNlbnNpdGl2ZSB2YWx1ZSA5NTIwYWUyM2E3MTA4ZmUxKQ== in the diff. It's not very intuitive.

Another small issue fixed is when set_sensitive is set but an empty string this effectively adds (sensitive value 123456) between each character in rendered manifest. This fix ignores empty sensitive values.

Acceptance tests

  • No new tests

Release Note

Release note for CHANGELOG:

* Manifest diff should show sensitive values as non-base64-encoded (sensitive value XXX) string.
* Passing empty value to `set_sensitive` is ignored in manifest diff.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

kkopachev avatar Jul 07 '22 18:07 kkopachev

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Jul 07 '22 18:07 hashicorp-cla