terraform-provider-helm icon indicating copy to clipboard operation
terraform-provider-helm copied to clipboard

Do dependency update in resourceDiff #771

Open WarpRat opened this issue 3 years ago • 1 comments

Description

Adding the dependency update function earlier in the provider flow. Currently attempting to use a template from a subchart in a template in the parent chart fails if linting or if the experimental manifest feature is enabled. Both the acceptance test and some local testing with the provider changes fix these issues. Running the new test without the dependency update change in resource_release.go fails as expected.

Fixes #771

Acceptance tests

  • [x] Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

The resourceDiff function now respects the dependency_update setting which fixes a bug in charts with dependencies that use linting or the experimental manifests feature.

References

#771

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

WarpRat avatar Apr 27 '22 08:04 WarpRat

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Apr 27 '22 08:04 hashicorp-cla

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Oct 12 '22 02:10 github-actions[bot]