terraform-provider-aws icon indicating copy to clipboard operation
terraform-provider-aws copied to clipboard

feat(eks): added `force` argument for eks cluster version upgrade

Open hjoshi123 opened this issue 7 months ago • 3 comments

Description

This PR introduces the force flag required for upgrading cluster when there are upgrade insights which might block it in the future.

Relations

Closes #42031. Closes https://github.com/hashicorp/terraform-provider-aws/pull/42140.

References

Output from Acceptance Testing

make testacc TESTS=TestAccEKSCluster_ForceUpgradeVersion PKG=eks
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20 -run='TestAccEKSCluster_ForceUpgradeVersion'  -timeout 360m -vet=off
2025/04/04 09:18:32 Initializing Terraform AWS Provider...
=== RUN   TestAccEKSCluster_ForceUpgradeVersion
=== PAUSE TestAccEKSCluster_ForceUpgradeVersion
=== CONT  TestAccEKSCluster_ForceUpgradeVersion
--- PASS: TestAccEKSCluster_ForceUpgradeVersion (1283.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	1289.168s
...

hjoshi123 avatar Apr 04 '25 16:04 hjoshi123

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! :rocket:

Voting for Prioritization

  • Please vote on this Pull Request by adding a :+1: reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions[bot] avatar Apr 04 '25 16:04 github-actions[bot]

@hjoshi123 Thanks for the contribution :tada: :clap:. I renamed the new argument force_update_version to match the equivalent on aws_eks_node_group: https://github.com/hashicorp/terraform-provider-aws/pull/13414.

ewbankkit avatar Apr 05 '25 21:04 ewbankkit

@hjoshi123 Thanks for the contribution :tada: :clap:.

I renamed the new argument force_update_version to match the equivalent on aws_eks_node_group: https://github.com/hashicorp/terraform-provider-aws/pull/13414.

Oh that's nice. Yeah I thought of naming it that but then kept it to match the AWS param. But that's makes it more readable for clients. 🎉

hjoshi123 avatar Apr 06 '25 01:04 hjoshi123

@hjoshi123 Thanks for the contribution :tada: :clap:.

ewbankkit avatar Apr 11 '25 12:04 ewbankkit

[!WARNING] This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions[bot] avatar Apr 11 '25 12:04 github-actions[bot]

This functionality has been released in v5.95.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] avatar Apr 17 '25 22:04 github-actions[bot]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar May 18 '25 02:05 github-actions[bot]