techdebt: migrating to golangci-lint v2

[hjoshi123]

Description

This PR adds golangci-lint v2 config and its corresponding github action.

Relations

Closes #41982

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions[bot]]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! :rocket:

Voting for Prioritization

• Please vote on this Pull Request by adding a :+1: reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[hjoshi123]

@justinretzolk do you know why the tests are stuck pending?

[ewbankkit]

@hjoshi123 It was something to do with the version of Ubuntu used on our custom runners.

[hjoshi123]

@ewbankkit / @justinretzolk fixed all the issues except the 4th golang ci lint.. review and staticcheck seems to be acting up with mostly comments.. not sure if we need to exclude those. On a side note, gosimple is merged with staticcheck so had to move all of it to a different lint file.

[github-actions[bot]]

:warning: We've detected the following potential issues with your pull request

Changelog Entry Required

The proposed change requires a changelog entry. Please see the Changelog Process section of the contributing guide for information on the changelog generation process.

[ewbankkit]

@hjoshi123 Thanks for the contribution :tada: :clap:.

[github-actions[bot]]

[!WARNING] This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions[bot]]

This functionality has been released in v5.98.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.