terraform-provider-ad icon indicating copy to clipboard operation
terraform-provider-ad copied to clipboard

Update winrm to fix unicode encoding issues

Open sthetz opened this issue 1 year ago • 2 comments

Description

This PR updates masterzen/winrm dependency to make use of RunPSWithString function that encodes PowerShell command in UTF-16. This ensures correct encoding of unicode characters passed to powershell.exe

References

Related PRs in winrm repo:

https://github.com/masterzen/winrm/pull/111 https://github.com/masterzen/winrm/pull/97

This PR should also fix:

https://github.com/hashicorp/terraform-provider-ad/issues/172

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

sthetz avatar Mar 18 '24 18:03 sthetz

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Mar 18 '24 18:03 hashicorp-cla