terraform-plugin-framework icon indicating copy to clipboard operation
terraform-plugin-framework copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Consider changing attr.Value implementations in types package to have Value in their name

Open paddycarver opened this issue 4 years ago • 1 comments

It's very confusing to have types.String that doesn't define an actual type constraint, and instead holds a value. Maybe types.StringValue is clearer?

paddycarver avatar Jul 13 '21 17:07 paddycarver

I'm 👍 for this type of change -- I personally appreciate the pattern of {InterfaceTypeName} and {Concrete}{InterfaceTypeName} where possible.

bflad avatar Jul 13 '21 18:07 bflad

We're discussing a different approach to this problem over in #447, which will introduce its own breaking changes, so I think it is best to track it there. 👍

bflad avatar Sep 23 '22 20:09 bflad

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Oct 24 '22 02:10 github-actions[bot]