terraform-k8s icon indicating copy to clipboard operation
terraform-k8s copied to clipboard

Make the sensitive and the environmentVariable properties optional

Open jtyr opened this issue 3 years ago • 1 comments

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR is makes the sensitive and the environmentVariable properties of the spec.variables optional. This allows to write less cluttered YAML as the values are by default false and the property must be present only if the user wants to set it to true. This PR needs to be rebased once the PR #129 is merged to remove most of the changes in the CRD.

Manifest without this PR:

...
spec:
  variables:
    - key: key1
      value: null value 1
      sensitive: false
      environmentVariable: false
    - key: key2
      sensitive: true
      sensitive: false
      environmentVariable: false

Manifest with this PR:

...
spec:
  variables:
    - key: key1
      value: null value 1
    - key: key2
      sensitive: true

Release note for CHANGELOG:

The sensitive and the environmentVariable properties of spec.variables are optional

jtyr avatar Apr 11 '22 11:04 jtyr

This PR is rebased now.

jtyr avatar Jul 05 '22 09:07 jtyr