packer-plugin-vsphere icon indicating copy to clipboard operation
packer-plugin-vsphere copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

🚧 feat: add vapp properties

Open MrKeiKun opened this issue 2 years ago • 11 comments

MrKeiKun avatar Aug 05 '23 13:08 MrKeiKun

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Aug 05 '23 13:08 hashicorp-cla

Please merge, feature would be useful

@JenGoldstrich Can you review?

harlequin avatar Sep 11 '23 12:09 harlequin

@MrKeiKun Couls to please provide A summary and test results in the pull request description?

tenthirtyam avatar Oct 13 '23 04:10 tenthirtyam

CI is failing.

tenthirtyam avatar Oct 17 '23 10:10 tenthirtyam

✅ CI is now Successful. ✅ Marking as Ready for Review.

tenthirtyam avatar Nov 08 '23 18:11 tenthirtyam

Marking this as draft for further review and outcome testing before merging.

tenthirtyam avatar Nov 10 '23 15:11 tenthirtyam

Any Updates to this?

harlequin avatar Feb 13 '24 05:02 harlequin

Agree, I've still got the issue in #305. Would be good to get this merged even in a "beta state". Currently with OVF templates the only work around is to use ssh/remote-exec provisioners which are marked by hashicorp "last resort."

adeturner avatar Feb 13 '24 08:02 adeturner

@adeturner Can you please provide some examples for your ssh/remote exec to this issue? I guess this "last resort" solution will help many people until it's implemented ...

harlequin avatar Feb 13 '24 08:02 harlequin

@harlequin no worries, see remote_exec_workaround and the_vapp_ideal

adeturner avatar Feb 13 '24 09:02 adeturner

Thus far, I've not been able to perform a build that will apply these properties to an image with the vsphere-iso builder after building from the source/branch.

@MrKeiKun 👋 - could you please provide a summary, minimal configuration example, test results in the pull request description?

Without this information I am reticent to move this one forward until the this can be successfully tested.

tenthirtyam avatar Apr 09 '24 22:04 tenthirtyam

After taking a look at this pull request it seems to be insufficient since you must also enable the vApp Options before being able to apply the properties.

Based on this, I'll look at addressing this item for the v1.5.0 release whilst taking into consideration Lucas' comments.

Ryan Johnson Distinguished Engineer, VMware by Broadcom

tenthirtyam avatar Oct 02 '24 20:10 tenthirtyam