nomad-driver-podman icon indicating copy to clipboard operation
nomad-driver-podman copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Moves SELinux label assignment to affect only implicit mounts

Open fuero opened this issue 5 years ago • 2 comments

Fixes #65 by moving the SELinux label assignment above the handling of user-supplied volumes.

fuero avatar Sep 12 '20 23:09 fuero

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Sep 12 '20 23:09 hashicorp-cla

Hey @fuero can you fix your merge conflict? I am trying to get this reviewed and merged. See https://github.com/hashicorp/nomad-driver-podman/issues/184

jdoss avatar Sep 27 '22 18:09 jdoss

I have been running this patch in testing for a few weeks. It works great. If @fuero is unavailable to rebase, @tgross / @lgfa29 do you want me to create a new PR to get this merged?

jdoss avatar Oct 20 '22 11:10 jdoss

We should close this PR and use https://github.com/hashicorp/nomad-driver-podman/pull/196. This implementation will prevent CSI drivers from correctly labeling volume mounts with the correct SELinux contexts.

jdoss avatar Oct 20 '22 19:10 jdoss