consul icon indicating copy to clipboard operation
consul copied to clipboard

Update service-defaults - Complete configuration

Open joomn11 opened this issue 1 year ago • 6 comments

Description

fix misconfiguration of service-defaults Complete configuration

Testing & Reproduction steps

Links

PR Checklist

  • [x] updated test coverage
  • [x] external facing docs updated
  • [x] appropriate backport labels added
  • [x] not a security concern

joomn11 avatar Feb 19 '24 05:02 joomn11

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Feb 19 '24 05:02 hashicorp-cla

hi, @boruszak i want to merge this pr but vercel check task is not passed , i think i need to skip that task. can you show me how to skip that check task ?

joomn11 avatar Feb 21 '24 03:02 joomn11

@joomn11 Do you have an example of working service-defaults? We want to double check if this is correct prior to merging.

david-yu avatar Feb 21 '24 04:02 david-yu

hi, @david-yu i am using json format of service-defaults

/ # consul config read -kind service-defaults -name echo
{
    "Kind": "service-defaults",
    "Name": "echo",
    "Protocol": "http",
    "TransparentProxy": {},
    "MeshGateway": {},
    "Expose": {},
    "UpstreamConfig": {
        "Defaults": {
            "Protocol": "http",
            "ConnectTimeoutMs": 5000,
            "PassiveHealthCheck": {
                "Interval": 10000000000,
                "MaxFailures": 1,
                "BaseEjectionTime": 10000000000
            },
            "MeshGateway": {
                "Mode": "local"
            }
        }
    },
    "CreateIndex": 4685452,
    "ModifyIndex": 4685452
}

in json format , service-default i changed location of "UpstreamConfig.Defaults" location it should be inside of " UpstreamConfig" block , but it was outside of "UpstreamConfig"

and in hcl format, service-default "UpstreamConfig.Overrides" is should be multi block

joomn11 avatar Feb 23 '24 01:02 joomn11

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

github-actions[bot] avatar May 12 '24 01:05 github-actions[bot]

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

github-actions[bot] avatar Aug 26 '24 01:08 github-actions[bot]

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.

github-actions[bot] avatar Sep 25 '24 01:09 github-actions[bot]