support capital letters in AclBinding

[kevinschoonover]

trafficstars

Description

Updates AclBindings to support service names that contain capital letters. See https://github.com/hashicorp/consul/issues/20373 for more details.

closes https://github.com/hashicorp/consul/issues/20373

Testing & Reproduction steps

Follow this very well written doc and change the httpd service name in the last step to 'Httpd'

Links

PR Checklist

• [X] updated test coverage
• [X] external facing docs updated
• [ ] appropriate backport labels added
• [X] not a security concern

[jkirschner-hashicorp]

Hi @kevinschoonover,

Thank you for reporting the underlying issue you observed and submitted a PR against it.

Historically, Consul has been inconsistent about case sensitivity in some areas. Long-term, we're likely moving in the direction of all resource names (such as the name of a service) needing to be all lowercase and DNS compatible. In that future state, resource names would likely be forced to lowercase on creation/save (e.g., if you try to register a service name with uppercase characters, the saved name would be all lowercase). We're still working out how quickly we can move to that future state.

Requiring that service and node identities only support lowercase characters was actually intended as a step towards that desired future state. Making the change proposed here would work against that progression, so we are unlikely to merge such a change.

However, this does not change the fact that you are experiencing an issue now related to resource names with uppercase characters. More thought is needed to determine if there's an alternative approach that can be supported now (that doesn't run against the long term direction of requiring/converting to lowercase).

[github-actions[bot]]

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

[github-actions[bot]]

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.