consul icon indicating copy to clipboard operation
consul copied to clipboard

Website: Update Available Fields for ServiceDefaults CRD

Open sdoyle88 opened this issue 2 years ago • 1 comments

Description

The current website page for Service Defaults Configuration Entry displays the "partition" field under the metadata parent for the Kubernetes CRD for service-defaults. However, upon inspecting the CRD directly, the "partition" field is located under

spec:
  upstreamConfig:
    overrides:
       - partition

and

spec:
  upstreamConfig:
    defaults:
       - partition

In addition, it appears as though the namespace and name fields are missing from the defaults section of the upstreamConfig as well in the documentation.

As such, requesting the following changes from the website documentation (under the Available Fields section of the ServiceDefaults page)

  1. Added the Partition field under upstreamConfig: defaults: section
  2. Added the Partition field under the upstreamConfig: overrides: section
  3. Added the Name and Namespace fields under the upstreamConfig: defaults section
  4. Removed the Partition field from the metadata section

Testing & Reproduction steps

None, added/edited json for the website for documentation purposes

PR Checklist

  • [ ] updated test coverage
  • [X] external facing docs updated
  • [X] not a security concern

sdoyle88 avatar Jan 17 '23 20:01 sdoyle88

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Jan 17 '23 20:01 hashicorp-cla

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

github-actions[bot] avatar Apr 25 '23 01:04 github-actions[bot]

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.

github-actions[bot] avatar Jun 02 '23 01:06 github-actions[bot]