consul icon indicating copy to clipboard operation
consul copied to clipboard

Get sidecar weights from node service if not specified

Open mougams opened this issue 3 years ago • 2 comments

Description

The sidecar service weight was set to default values if not specified by use in connect block of service definition. This patch aims of reusing the node service weights if no weights is specified from connect definition block or if defined to default one.

Testing & Reproduction steps

Test has been updated

Links

This PR is a refresh of https://github.com/hashicorp/consul/pull/9335 And implements https://github.com/hashicorp/consul/issues/9334

PR Checklist

  • [x] updated test coverage
  • [x] external facing docs updated
  • [x] not a security concern

mougams avatar Oct 24 '22 10:10 mougams

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Oct 24 '22 10:10 hashicorp-cla

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

github-actions[bot] avatar Dec 25 '22 01:12 github-actions[bot]