consul icon indicating copy to clipboard operation
consul copied to clipboard

options.mdx: `addresses` affects client ifaces

Open asymmetric opened this issue 3 years ago • 8 comments
trafficstars

asymmetric avatar Apr 07 '22 16:04 asymmetric

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Apr 07 '22 16:04 hashicorp-cla

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

hashicorp-ci avatar Apr 07 '22 16:04 hashicorp-ci

Hey @asymmetric

Thanks for the contribution to the docs. I'm curious to know if the lack of clarification here ( not having it explicitly say" in client interfaces ") caused you some issues when managing your consul cluster?

Also, we'll need you to sign the CLA before giving this an official review, thank you!

Amier3 avatar Apr 12 '22 15:04 Amier3

@Amier3 yes, it was confusing while setting up a cluster as there are multiple options that deal with binding, and hhopefully this change helps clarify what the addresses option is for.

asymmetric avatar Apr 18 '22 11:04 asymmetric

@asymmetric

Ah okay , in that case I think this would be a welcome change 👍 . Once the CLA is signed we'll be happy to review & merge this in. Thank you!

Amier3 avatar Apr 26 '22 18:04 Amier3

@Amier3 i've signed the CLA.

asymmetric avatar May 06 '22 13:05 asymmetric

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

github-actions[bot] avatar Jul 06 '22 01:07 github-actions[bot]

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

github-actions[bot] avatar Sep 05 '22 01:09 github-actions[bot]

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.

github-actions[bot] avatar Oct 06 '22 01:10 github-actions[bot]