consul icon indicating copy to clipboard operation
consul copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

changelog: fix PR links

Open boxofrad opened this issue 3 years ago • 4 comments

I noticed that the PR links in our CHANGELOG.md don't seem to work anymore 🤔 I wonder if GitHub no longer supports the /issues/<id> path for Pull Requests?

boxofrad avatar Dec 10 '21 16:12 boxofrad

@eculver I wasn't able to figure out how to regenerate the entire changelog with changelog-build (particularly as the earlier entries predate the tool) so did a find-and-replace instead.

Interestingly, there are some older links to issues rather than PRs, but the /pull/<id> URL redirects to /issues/<id> correctly.

boxofrad avatar Dec 10 '21 21:12 boxofrad

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

github-actions[bot] avatar Feb 16 '22 01:02 github-actions[bot]

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Mar 12 '22 17:03 hashicorp-cla

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

github-actions[bot] avatar Sep 21 '22 01:09 github-actions[bot]

Spot checked a few of the old /issues/{PR_NUMBER} links and they appear to be working now. Pull requests are just a "special" type of issue in GitHub's data model/API, could this have been a temporary problem? Suggest we close this unless some are still definitively broken.

mikemorris avatar Sep 29 '22 19:09 mikemorris