consul-k8s icon indicating copy to clipboard operation
consul-k8s copied to clipboard

Terminating gateway service2

Open Oluwalogoye opened this issue 3 years ago • 3 comments
trafficstars

Changes proposed in this PR:

  • Create a crd for registering external services to consul. Its aim is to replace the first two manual components here. Read full details in RFC

How I've tested this PR:

  • go test ./... -run <unit test function name>

How I expect reviewers to test this PR:

  • go test ./... -run TestReconcileCreateTerminatingGatewayService
  • go test ./... -run TestReconcile_DeleteTerminatingGatewayService

CHANGELOG

  • Created a new CRD with operator-sdk create api --group consul --version v1alpha1 --kind TerminatingGatewayService --controller --namespaced=true --make=false --resource=true
  • Made changes to the reconcile function of TerminatingGatewayService to register the services
  • Added tests in terminatinggatewayservice_test.go
  • Ran make ctrl-generate, make-ctrl-manifests

Checklist:

  • [ ] Tests added
  • [ ] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry. Entries should use present tense (e.g. Add support for...)

Oluwalogoye avatar Jul 18 '22 22:07 Oluwalogoye

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Jul 18 '22 22:07 hashicorp-cla

That would help with the troublesome implementation I have setup with Terraform and consul provider.

manobi avatar Jul 19 '22 00:07 manobi

Great work on this Logo-- this looks great, and we'll just hold off on merging until we finish reviewing the RFC design

ndhanushkodi avatar Aug 09 '22 05:08 ndhanushkodi