consul-k8s
consul-k8s copied to clipboard
Terminating gateway service2
trafficstars
Changes proposed in this PR:
- Create a crd for registering external services to consul. Its aim is to replace the first two manual components here. Read full details in RFC
How I've tested this PR:
go test ./... -run <unit test function name>
How I expect reviewers to test this PR:
go test ./... -run TestReconcileCreateTerminatingGatewayServicego test ./... -run TestReconcile_DeleteTerminatingGatewayService
CHANGELOG
- Created a new CRD with
operator-sdk create api --group consul --version v1alpha1 --kind TerminatingGatewayService --controller --namespaced=true --make=false --resource=true - Made changes to the reconcile function of TerminatingGatewayService to register the services
- Added tests in terminatinggatewayservice_test.go
- Ran
make ctrl-generate,make-ctrl-manifests
Checklist:
- [ ] Tests added
- [ ] CHANGELOG entry added
HashiCorp engineers only, community PRs should not add a changelog entry. Entries should use present tense (e.g. Add support for...)
That would help with the troublesome implementation I have setup with Terraform and consul provider.
Great work on this Logo-- this looks great, and we'll just hold off on merging until we finish reviewing the RFC design