boundary
boundary copied to clipboard
hashicorp
Backport of fix(worker): set session.CloseCallTimeout to non-zero value into release/0.18.x
Backport
This PR is auto-generated from #5510 to be assessed for backporting due to the inclusion of the label backport/0.18.x.
:rotating_light:
Warning automatic cherry-pick of commits failed. If the first commit failed, you will see a blank no-op commit below. If at least one commit succeeded, you will see the cherry-picked commits up to, not including, the commit where the merge conflict occurred.
The person who merged in the original PR is: @ddebko This person should manually cherry-pick the original PR into a new backport PR, and close this one when the manual backport PR is merged in.
merge conflict error: POST https://api.github.com/repos/hashicorp/boundary/merges: 409 Merge conflict []
The below text is copied from the body of the original PR.
Summary
The variable newConf.Worker.SuccessfulControllerRPCGracePeriod is a any type, which defaults to nil. The case statement would then match on the default case, where the SuccessfulControllerRPCGracePeriodDuration was not set. This would then have a cascading affect of causing immediate timeouts for anything that was referencing the session.CloseCallTimeout variable.
Overview of commits
- 6e8d6a1ed2225f43ee27f196405de09ec75abedb
