boundary icon indicating copy to clipboard operation
boundary copied to clipboard

Daniellemiu add Staticcheck to Build Pipeline

Open kheina opened this issue 3 years ago • 2 comments
trafficstars

currently omits error ST1005 for error string formatting since boundary errors violate Staticcheck's rules for these (don't start error strings with a capital and don't end error strings with punctuation)

go vet is also disabled as a step currently as it also produces a lot of errors (and isn't necessary to run Staticcheck) the list of errors it produces can be found here or can be run in the terminal

kheina avatar Sep 02 '22 18:09 kheina

Only 230 errors left 😂

johanbrandhorst avatar Sep 02 '22 19:09 johanbrandhorst

Can we use golangci-lint instead of calling individual linters directly? This would make it easier to introduce additional linters as we see fix. It also provides a nice option to only detect new errors relative to a git revision. So we can check just new code in a PR without needing to fix all existing code. This makes it easier to add a CI check and have it be green.

I have a (rather old) branch that was a proof of concept on this here.

tmessi avatar Sep 07 '22 14:09 tmessi