boundary-ui
boundary-ui copied to clipboard
hashicorp
Upgrade node engines to work with node 20 and 22
Description
Upgrade node engines to work with node 20 and 22.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| boundary-ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 11, 2025 1:19am |
| boundary-ui-desktop | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 11, 2025 1:19am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
should we also consider using the same version in boundary-ui-releases?
@cameronperera
Good point.
Some thinking loud:
- Right now 20 is LTS, so we should keep node 20 support IMHO.
- As you mention 22 is current.
- So we should keep support for: 20 and 22.
is that correct?
@cameronperera
Good point.
Some thinking loud:
- Right now 20 is LTS, so we should keep node 20 support IMHO.
- As you mention 22 is current.
- So we should keep support for: 20 and 22.
is that correct?
Correct. If we are going to upgrade our supported node version, we should probably stick to the LTS versions. Plus v22 doesn't start it's maintenance schedule until a year from now. So this should hold us for a while.
@DhariniJeeva
We keep supporting node 20. For now, I will suggest to keep the pipeline with node 20. Upgrading node in the pipeline requires more work, specially testing. We just upgrade the pipeline from 18 to 20 so IMHo its fine for a while. Something I will like to explore once TS is released.
Thoughts?
@DhariniJeeva
We keep supporting node 20. For now, I will suggest to keep the pipeline with node 20. Upgrading node in the pipeline requires more work, specially testing. We just upgrade the pipeline from 18 to 20 so IMHo its fine for a while. Something I will like to explore once TS is released.
Thoughts?
that sounds good!
@DhariniJeeva
Due to reverting the node20 upgrade changes within boundary-ui-releases I will hold this PR until we can run node20 within the pipeline.
@calcaide did you run a script to update node v in different files, or was this manual? Just wondering how we handle upgrades.
@laurenolivia
I did perform this manually.
This PR updates the engines key within package.json, it will be developer responsability to upgrade acordingly the node version use within the dev enviornment.