boundary-ui icon indicating copy to clipboard operation
boundary-ui copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

configure Desktop logging

Open DhariniJeeva opened this issue 1 year ago • 6 comments
trafficstars

:tickets: Jira ticket

Description

This PR installs electron log to add logs to desktop client.

Screenshots (if appropriate):

How to Test

  • run binary locally and perform search on DC
  • you can see the log file being generated in the below mentioned location based on your OS

on Linux: ~/.config/{app name}/logs/main.log on macOS: ~/Library/Logs/{app name}/main.log on Windows: %USERPROFILE%\AppData\Roaming{app name}\logs\main.log

:technologist: Admin preview

:desktop_computer: Desktop preview

Checklist:

  • [ ] I have added before and after screenshots for UI changes
  • [ ] I have added JSON response output for API changes
  • [ ] I have added steps to reproduce and test for bug fixes in the description
  • [ ] I have commented on my code, particularly in hard-to-understand areas
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works

DhariniJeeva avatar Mar 27 '24 22:03 DhariniJeeva

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ❌ Failed (Inspect) Mar 27, 2024 10:54pm
boundary-ui-desktop ❌ Failed (Inspect) Mar 27, 2024 10:54pm

vercel[bot] avatar Mar 27 '24 22:03 vercel[bot]

I will suggest to add a log when we detect the clientDaemon is failing and we fall back to the controller, not sure should be here, but somewhere around there. The idea of my suggestion is to know:

  • When and how often the daemon fails and we need to fallback to the controller.
  • To know if we are fetching from daemon or controller.

calcaide avatar Mar 28 '24 18:03 calcaide

Awesome!! this is looking great @DhariniJeeva !!

calcaide avatar Mar 28 '24 18:03 calcaide

Is this going to get merged into main? What was the plan for this?

ZedLi avatar Mar 28 '24 18:03 ZedLi

Ups!! good catch @ZedLi , definetly this should be in a feature or LL branch, so we can keep working on it, build experimental binaries if need until we decide to bring it to main

calcaide avatar Mar 28 '24 21:03 calcaide

I wasn't sure when we would merge this or what the scope of this work is, but for now, as Carlos suggested, I will create an LLB for this work.

DhariniJeeva avatar Mar 28 '24 21:03 DhariniJeeva

Closed as this was now handled in https://github.com/hashicorp/boundary-ui/pull/2234

ZedLi avatar Apr 15 '24 15:04 ZedLi