feat: 🎸 Re-enabling footer for Boundary Admin UI

[dvonanderson]

trafficstars

Re-enable global footer and fix styling

✅ Closes: ICU-6454

:tickets: Jira ticket

Description

The global footer should be visible to bring Boundary into alignment with other products

:technologist: Admin preview

:rose: Rose preview

:desktop_computer: Desktop preview

Screenshots (if appropriate):

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
boundary-ui	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Nov 1, 2022 at 11:04PM (UTC)
boundary-ui-desktop	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Nov 1, 2022 at 11:04PM (UTC)
boundary-ui-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Nov 1, 2022 at 11:04PM (UTC)

[ZedLi]

I have a general question regarding the layout of the footer

currently it looks like this:

should it be more like this:

We can still align to the center of the screen but I guess it's a question of what we should do when the screen shrinks like this and whether it should go over the sidebar:

[dvonanderson]

I have a general question regarding the layout of the footer

currently it looks like this:

should it be more like this:

We can still align to the center of the screen but I guess it's a question of what we should do when the screen shrinks like this and whether it should go over the sidebar:

@ZedLi your bottom example is the original way that I wanted to correct the display system for global-layout, but because the footer is part of the global-layout itself and the sidebar is part of the global-layout-body and the main content is yielded through the sidebar-layout so couldn't really target the side-sidebar specifically, but what I can do is change the media query to provide a different view based on screen size.

[dvonanderson]

@ZedLi what you think?

[calcaide]

I do agree with @ZedLi

I think the approach we should follow is

To me, in this case makes more sense a change on the layout to follow a natural flow.

What do you think?

Good work!! thank you for this

[dvonanderson]

I am also wondering if we really need a footer for the login in page? Looking at HCP and they seem to ditch it for the login and password reset screen. Also if we do need it should the content of the footer be centered in those two layouts?

[joshuaogle]

@dvonanderson I'm pretty sure HCP is only hiding theirs because of the layout on that page. I don't think the footer looks bad in the corner, but centered might be less distracting. Which one feels better to you?

[dvonanderson]

@dvonanderson I'm pretty sure HCP is only hiding theirs because of the layout on that page. I don't think the footer looks bad in the corner, but centered might be less distracting. Which one feels better to you?

I think it looks great there!