aws-sdk-go-base icon indicating copy to clipboard operation
aws-sdk-go-base copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Introduce settings flag to stop execution if expired credentials error happen

Open Dziman opened this issue 5 years ago • 4 comments
trafficstars

Changes proposed in this pull request:

Introduce new settings parameter to stop retrying if AWS credentials are expired. To keep existing behavior (retry MaxRetries times) defaulted to false

Dziman avatar Apr 05 '20 01:04 Dziman

CLA assistant check
All committers have signed the CLA.

hashicorp-cla avatar Apr 05 '20 01:04 hashicorp-cla

@Dziman anyway we can help to get this merged?

jjoos avatar Apr 15 '20 12:04 jjoos

We encountered this issue as well, this patch really helps to prevent the system to get into a incomplete state.

jgelens avatar Apr 15 '20 12:04 jgelens

@Dziman anyway we can help to get this merged?

@jjoos if you can somehow reach maintainers and convince them this change should be merged ASAP :)

Dziman avatar Apr 23 '20 07:04 Dziman

@Dziman Thank you very much for your work on this so long ago! We apologize for the delay. In essence, AWS fixed this problem so we did not end up needing the approach that you took.

YakDriver avatar Feb 22 '23 18:02 YakDriver