hedera-sdk-js icon indicating copy to clipboard operation
hedera-sdk-js copied to clipboard

docs: add some comments about the `toSolidityAddress` function

Open Neurone opened this issue 1 year ago • 2 comments

Description: toSolidityAddress function can be misleading; see this StackOverflow issue for details.

This PR adds some comments to make the usage of that function clearer.

Related issue(s):

N/A

Notes for reviewer:

N/A

Checklist

  • [x] Documented (Code comments, README, etc.)
  • [x] Tested (unit, integration, etc.)

Neurone avatar Mar 25 '24 17:03 Neurone

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 25 '24 17:03 sonarqubecloud[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.49%. Comparing base (5467a47) to head (4c75bbc).

:exclamation: Current head 4c75bbc differs from pull request most recent head db36ceb. Consider uploading reports for the commit db36ceb to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2220   +/-   ##
========================================
  Coverage    84.48%   84.49%           
========================================
  Files          305      305           
  Lines        76285    76287    +2     
========================================
+ Hits         64448    64457    +9     
+ Misses       11837    11830    -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 25 '24 17:03 codecov-commenter

Hmmm thanks for this. If I understood you correctly then MirrorNodeContractQuery's setSender functionality might not work as expected in a specific scenario. I will check it and create an issue for it. Thanks for raising this.

ivaylonikolov7 avatar Mar 16 '25 21:03 ivaylonikolov7

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files with missing lines Coverage Δ
src/account/AccountId.js 75.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 16 '25 21:03 codecov[bot]