hedera-json-rpc-relay icon indicating copy to clipboard operation
hedera-json-rpc-relay copied to clipboard

Remove redundant env config values from helm charts

Open AlfredoG87 opened this issue 1 year ago • 0 comments

Problem

The relay has the recommended and default values hardcoded within the app. however we are overriding these with the one with the chart values, what is forcing devs to update the defaults in both places when there is a change or optimization, and in some cases there is an inconsistency between them due to devs forget about the charts.

NOTE IMPORTANT:

There are already some outdated values for the charts, like: Default on app:

  MIRROR_NODE_RETRIES: 0
  MIRROR_NODE_RETRY_DELAY: 2000
  HAPI_CLIENT_ERROR_RESET: [21,50]

Overriden on chart default values:

  MIRROR_NODE_RETRIES: 3
  MIRROR_NODE_RETRY_DELAY: 250
  HAPI_CLIENT_ERROR_RESET: [50]

There are more that change, so is necessary to evaluate if the difference is really needed...

Solution

review and remove all duplicate and default values from the chart values files.

review files:

  • https://github.com/hashgraph/hedera-json-rpc-relay/blob/main/charts/hedera-json-rpc-relay/values.yaml
  • https://github.com/hashgraph/hedera-json-rpc-relay/blob/main/charts/hedera-json-rpc-relay/value-test.yaml
  • https://github.com/hashgraph/hedera-json-rpc-relay/blob/main/charts/hedera-json-rpc-relay-websocket/values.yaml

leave as few configs on the values as possible only when there is a real need to have it different than the defaults on app.

Alternatives

No response

AlfredoG87 avatar May 11 '24 03:05 AlfredoG87