hedera-json-rpc-relay icon indicating copy to clipboard operation
hedera-json-rpc-relay copied to clipboard

fix: Populate null values in transactions.

Open ebadiere opened this issue 1 year ago • 4 comments

Populates null values in transactions.

Related issue(s):

Fixes #2451

ebadiere avatar May 08 '24 23:05 ebadiere

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.79%. Comparing base (07cb2d7) to head (62a04d7). Report is 2 commits behind head on main.

:exclamation: Current head 62a04d7 differs from pull request most recent head 374e8fd. Consider uploading reports for the commit 374e8fd to get more accurate results

Files Patch % Lines
packages/relay/src/lib/eth.ts 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2467      +/-   ##
==========================================
+ Coverage   77.29%   77.79%   +0.50%     
==========================================
  Files          40       27      -13     
  Lines        3228     2585     -643     
  Branches      663      546     -117     
==========================================
- Hits         2495     2011     -484     
+ Misses        524      409     -115     
+ Partials      209      165      -44     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 08 '24 23:05 codecov-commenter

Acceptance Tests

  20 files  263 suites   24m 53s :stopwatch: 586 tests 579 :heavy_check_mark: 3 :zzz: 4 :x: 904 runs  889 :heavy_check_mark: 7 :zzz: 8 :x:

Results for commit d3f4f640.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 08 '24 23:05 github-actions[bot]

Tests

    2 files  147 suites   13s :stopwatch: 821 tests 820 :heavy_check_mark: 1 :zzz: 0 :x: 833 runs  832 :heavy_check_mark: 1 :zzz: 0 :x:

Results for commit d3f4f640.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 09 '24 13:05 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 10 '24 14:05 sonarqubecloud[bot]

Replaced by #2495

ebadiere avatar May 15 '24 03:05 ebadiere