hedera-json-rpc-relay icon indicating copy to clipboard operation
hedera-json-rpc-relay copied to clipboard

Add return types to subscriptionController file

Open konstantinabl opened this issue 1 year ago • 3 comments

Problem

Return types for some functions in the subscriptionController file are missing

Solution

Add return types, where needed

Alternatives

No response

konstantinabl avatar Apr 09 '24 16:04 konstantinabl

Could you please give me a little more context on this issue?

quiet-node avatar Apr 15 '24 03:04 quiet-node

@quiet-node For example function below has no return type: Screenshot 2024-04-15 at 16 41 58

Should be like this: Screenshot 2024-04-15 at 16 42 48

Thats a good practice and it actually makes sense, since this is one of the reasons why typescript is used

konstantinabl avatar Apr 15 '24 13:04 konstantinabl

Ah I see! Yes indeed that's a good practice!

quiet-node avatar Apr 15 '24 16:04 quiet-node